Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply metadata from the pre-MIRA model to the post-MIRA model if the name of variables matches #5181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apply metadata from the pre-MIRA model to the post-MIRA model if the name of variables matches #5181

wants to merge 2 commits into from
+209 −17

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Oct 17, 2024

YohannParis
YohannParis approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.../main/java/software/uncharted/terarium/hmiserver/controller/dataservice/ModelController.java
Comment on lines +194 to +195
// Append the Document extractions to the Model extractions, just for the
// front-end.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgauldie Do we still do this? Maybe in another PR when we remove SKEMA-TR

mwdchang
mwdchang approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, code looks okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang mwdchang approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbirk @YohannParis @mwdchang